Coming from someone who spent the first part of their life in upstate New York (Syracuse), avoid it if possible.
It's not a terrible place (certainly not compared to Detroit), but the winters are long, brutal, and depressing. I have extended family in Buffalo and they're reasonably happy but...