yeah i agree, teams have certainly made worse trades.
Weaver is a middle-to-back of the rotation type arm. still youngish, decent stuff, decent control, struggles a bit with lefties, nothing special. he'll be a lot more variant in the NL West in Chase & Coors where he's likely to get blown up...